Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JetBrains default dark theme #9967

Merged
merged 3 commits into from
Mar 30, 2024
Merged

Add JetBrains default dark theme #9967

merged 3 commits into from
Mar 30, 2024

Conversation

ynuwenhof
Copy link
Contributor

Hey, I have attempted to recreate the default JetBrains dark theme in Helix as closely as possible.

WindowsTerminal_sGGQRwZ525

@kirawi kirawi added the A-theme Area: Theme and appearence related label Mar 23, 2024
@the-mikedavis the-mikedavis added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Mar 25, 2024
the-mikedavis
the-mikedavis previously approved these changes Mar 25, 2024
View reviewed changes
@the-mikedavis the-mikedavis added S-waiting-on-review Status: Awaiting review from a maintainer. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 25, 2024
@peteringram0
Copy link

Small gripe. If you enable bufferline = "always" its not clear which tab you are on. I know everyone doesn't enable this but the theme becomes so much better when its clear which buffer is active.

@ynuwenhof
Copy link
Contributor Author

Small gripe. If you enable bufferline = "always" its not clear which tab you are on. I know everyone doesn't enable this but the theme becomes so much better when its clear which buffer is active.

I have added a custom foreground color to differentiate between active and inactive buffers.

@archseer archseer merged commit 787a237 into helix-editor:master Mar 30, 2024
6 checks passed
@krish-r krish-r mentioned this pull request Mar 31, 2024
Merged
Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Apr 3, 2024
@ynuwenhof @Desdaemon
Add JetBrains default dark theme (helix-editor#9967)
176ffa3
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@ynuwenhof @postsolar
Add JetBrains default dark theme (helix-editor#9967)
3a6f073
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@ynuwenhof @postsolar
Add JetBrains default dark theme (helix-editor#9967)
4fda1e2
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
@ynuwenhof @postsolar
Add JetBrains default dark theme (helix-editor#9967)
b958252
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
@ynuwenhof @postsolar
Add JetBrains default dark theme (helix-editor#9967)
12987d7
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
@ynuwenhof @mtoohey31
Add JetBrains default dark theme (helix-editor#9967)
995264a
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
@ynuwenhof @Vulpesx
Add JetBrains default dark theme (helix-editor#9967)
13d214a
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
@ynuwenhof
Add JetBrains default dark theme (helix-editor#9967)
2734ccf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ynuwenhof @peteringram0 @archseer @the-mikedavis @kirawi